Fix stale playout state across multi-step voice turns#5533
Open
jayeshp19 wants to merge 2 commits intolivekit:mainfrom
Open
Fix stale playout state across multi-step voice turns#5533jayeshp19 wants to merge 2 commits intolivekit:mainfrom
jayeshp19 wants to merge 2 commits intolivekit:mainfrom
Conversation
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
jayeshp19
force-pushed
the
Fix-stale-playout-state-across-multi-step-voice-turns
branch
from
efc3ae3 to
efcb35c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where paused-speech state could become stale across generation steps within a single
SpeechHandle. The key changes are:current_generation_playout_activeflag onSpeechHandle— tracks whether the current generation's audio is actively playing, reset on each step advance.generation_stepfield on_PausedSpeechInfo— ensures paused speech is only applied/resumed if it matches the current generation step._on_generation_playout_started/_on_generation_playout_finished— extracts duplicated playout lifecycle logic (state updates, audio recognition notifications, interruption toggling) into two reusable methods.The audio-interruption condition now also gates on
current_generation_playout_active, preventing interruptions when the agent isn't actually playing audio for the current generation.